Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move AnimatedPulse to components-temp and add storybook page #13469

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

digiwand
Copy link
Contributor

Description

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the No E2E Smoke Needed If the PR does not need E2E smoke test run label Feb 12, 2025
@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 12, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 61.85%. Comparing base (1937f9a) to head (a7e6006).
Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
...nents-temp/AnimatedPulse/AnimatedPulse.stories.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13469      +/-   ##
==========================================
+ Coverage   61.58%   61.85%   +0.26%     
==========================================
  Files        1953     1975      +22     
  Lines       43442    43838     +396     
  Branches     5835     5916      +81     
==========================================
+ Hits        26753    27115     +362     
- Misses      14905    14925      +20     
- Partials     1784     1798      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants