feat: add AlertModal component
#13483
Draft
+1,146
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps `elliptic` in the dependency tree to mitigate the following security advisories: - https://github.com/MetaMask/metamask-mobile/security/dependabot/154 - https://github.com/MetaMask/metamask-mobile/security/dependabot/146 - https://github.com/MetaMask/metamask-mobile/security/dependabot/129 - https://github.com/MetaMask/metamask-mobile/security/dependabot/128 - https://github.com/MetaMask/metamask-mobile/security/dependabot/127 The closer version that mitigates all the above advisories is `6.6.0`. Currently on `main`, these are the versions we have for `elliptic`: ```bash > yarn why elliptic => Found "[email protected]" info Has been hoisted to "elliptic" info Reasons this module exists - Hoisted from "@WalletConnect#utils#elliptic" - Hoisted from "@MetaMask#ppom-validator#elliptic" - Hoisted from "secp256k1#elliptic" - Hoisted from "ethereumjs-abi#ethereumjs-util#elliptic" - Hoisted from "react-native-crypto#create-ecdh#elliptic" - Hoisted from "react-native-crypto#browserify-sign#elliptic" - Hoisted from "ethereumjs-util#secp256k1#elliptic" info Disk size without dependencies: "288KB" info Disk size with unique dependencies: "656KB" info Disk size with transitive dependencies: "656KB" info Number of shared dependencies: 7 => Found "@ethersproject/signing-key#[email protected]" info This module exists because "ethers#@ethersproject#signing-key" depends on it. info Disk size without dependencies: "288KB" info Disk size with unique dependencies: "656KB" info Disk size with transitive dependencies: "656KB" info Number of shared dependencies: 7 => Found "@reown/walletkit#[email protected]" info Reasons this module exists - "@WalletConnect#se-sdk#@Reown#walletkit#@WalletConnect#utils" depends on it - Hoisted from "@WalletConnect#se-sdk#@Reown#walletkit#@WalletConnect#utils#elliptic" info Disk size without dependencies: "172KB" info Disk size with unique dependencies: "540KB" info Disk size with transitive dependencies: "540KB" info Number of shared dependencies: 7 => Found "@walletconnect/sign-client#[email protected]" info Reasons this module exists - "@WalletConnect#se-sdk#@Reown#walletkit#@WalletConnect#sign-client#@WalletConnect#utils" depends on it - Hoisted from "@WalletConnect#se-sdk#@Reown#walletkit#@WalletConnect#sign-client#@WalletConnect#utils#elliptic" info Disk size without dependencies: "172KB" info Disk size with unique dependencies: "540KB" info Disk size with transitive dependencies: "540KB" info Number of shared dependencies: 7 ``` The added resolution forces the package on `^6.6.0` which currently resolves to `6.6.1` ## **Related issues** Related: MetaMask/core#4847 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Mark Stacey <[email protected]>
## **Description** I recently [added working directory for the last step of the Github action](#13419) but not for the dependancies installation step. It is needed there as well. ## **Related issues** None ## **Manual testing steps** None, this PR needs to be merged to retry the Github action. But it should work as we've already done similar fixes for other Github actions ([example here](https://github.com/MetaMask/metamask-mobile/blob/main/.github/workflows/check-template-and-add-labels.yml#L25)). ## **Screenshots/Recordings** [Here's](https://github.com/MetaMask/metamask-mobile/actions/runs/13263497997/job/37025196242) where the issue occured. <img width="1390" alt="Screenshot 2025-02-11 at 11 21 58" src="https://github.com/user-attachments/assets/d7eda6c9-7b68-4289-b12a-99b59fa6cb4b" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
## Explanation Rename `RestrictedControllerMessenger` to `RestrictedMessenger` and `ControllerMessenger` to `Messenger`. ## References Relates to [#4538](MetaMask/core#4538) ## Changelog No functional changes. ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** 7.39.0 changeset `stable` sync with `main` ## **Related issues** Fixes: NA ## **Manual testing steps** 1. NA 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** NA <!-- [screenshots/recordings] --> ### **After** NA <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #13409 ## **Manual testing steps** 1. Choose BNB or AVAX network 2. process send of native token 3. check if there's no duplicated asset entry ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/570c8e7f-c709-48c5-9fb8-c091081dcc2c ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add a new component for the alert system
AlertModal.Until we add an alert there is no functional change in the app.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist