Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix account selector balance #13484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix account selector balance #13484

wants to merge 1 commit into from
+1 −1

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 13, 2025 •
edited
Loading

Description

PR to fix account selector balance

Related issues

Fixes: #13476

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen.Recording.2025-02-13.at.16.07.26.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 13, 2025
@sahar-fehri sahar-fehri marked this pull request as ready for review February 13, 2025 15:09
@sahar-fehri sahar-fehri requested a review from a team as a code owner February 13, 2025 15:09
@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: badb21f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/95ae78c2-34f7-4361-adee-adff357e2be6

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sleepytanya sleepytanya added the QA Passed A successful QA run through has been done label Feb 13, 2025
@sleepytanya
Copy link
Contributor

Balance in the Account selector is correctly updated:
builds: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a1f4a161-9a70-46e0-8513-5fc1c2fad360?tab=artifacts

Screen_Recording_20250213_105754_MetaMask.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salimtb salimtb salimtb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. QA Passed A successful QA run through has been done Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
None yet
Milestone
No milestone
4 participants
@sahar-fehri @sleepytanya @salimtb @metamaskbot