-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typos #7764
base: main
Are you sure you want to change the base?
chore: fix typos #7764
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
if you could preserve the original PR template too, that would be great |
@leotm Thanks for you review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7764 +/- ##
=======================================
Coverage 40.21% 40.21%
=======================================
Files 1234 1234
Lines 29883 29883
Branches 2862 2862
=======================================
Hits 12017 12017
Misses 17175 17175
Partials 691 691 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you @shuoer86 🙏 Can we get an mobile engineer that is familiar with the locales keys to ensure the error_occured
=> error_occurred
key update is valid otherwise LGTM! Out of curiosity what tool did you use to catch all of these? Thanks for your contribution 🙏
@georgewrmarshall I would like to add code speller workflow in CI if needed |
@georgewrmarshall @brianacnguyen @leotm thanks for your reviews again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution @shuoer86 🙏
- Searched to confirm no instances of
error_occured
remain ✅
@brianacnguyen Could you help to merge it? Thank you very much. |
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
7e1d922
@georgewrmarshall @brianacnguyen @leotm I rebased to resolved the new coming conflict. Please help me to review again. Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Not sure why e2e tests are failing is this to do with open source contributions @leotm?
@georgewrmarshall @brianacnguyen @leotm |
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions. |
Description
Fix typos
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist