Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #7764

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

chore: fix typos #7764

wants to merge 8 commits into from

Conversation

shuoer86
Copy link

@shuoer86 shuoer86 commented Nov 11, 2023

Description

Fix typos

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@shuoer86 shuoer86 requested a review from a team as a code owner November 11, 2023 03:47
Copy link
Contributor

github-actions bot commented Nov 11, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Nov 11, 2023
@shuoer86
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

leotm
leotm previously approved these changes Nov 16, 2023
app/components/UI/Drawer/index.tsx Show resolved Hide resolved
@leotm
Copy link
Member

leotm commented Nov 16, 2023

if you could preserve the original PR template too, that would be great

@shuoer86
Copy link
Author

@leotm Thanks for you review.

@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93ce2e2) 40.21% compared to head (f59b589) 40.21%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7764   +/-   ##
=======================================
  Coverage   40.21%   40.21%           
=======================================
  Files        1234     1234           
  Lines       29883    29883           
  Branches     2862     2862           
=======================================
  Hits        12017    12017           
  Misses      17175    17175           
  Partials      691      691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shuoer86 shuoer86 requested a review from a team as a code owner November 30, 2023 11:46
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you @shuoer86 🙏 Can we get an mobile engineer that is familiar with the locales keys to ensure the error_occured => error_occurred key update is valid otherwise LGTM! Out of curiosity what tool did you use to catch all of these? Thanks for your contribution 🙏

@shuoer86
Copy link
Author

shuoer86 commented Dec 5, 2023

@georgewrmarshall I would like to add code speller workflow in CI if needed

@shuoer86
Copy link
Author

@georgewrmarshall @brianacnguyen @leotm thanks for your reviews again.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @shuoer86 🙏

  • Searched to confirm no instances of error_occured remain ✅

Screenshot 2024-01-04 at 10 29 47 AM

brianacnguyen
brianacnguyen previously approved these changes Jan 4, 2024
@shuoer86
Copy link
Author

@brianacnguyen Could you help to merge it? Thank you very much.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Apr 11, 2024
@shuoer86
Copy link
Author

@georgewrmarshall @brianacnguyen @leotm

I rebased to resolved the new coming conflict.

Please help me to review again. Thank you very much!

@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Apr 12, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Not sure why e2e tests are failing is this to do with open source contributions @leotm?

@shuoer86
Copy link
Author

@georgewrmarshall @brianacnguyen @leotm
Could you help to merge when approved.

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Aug 15, 2024
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner August 15, 2024 17:10
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Mobile label Aug 15, 2024
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Aug 15, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Nov 13, 2024
@gauthierpetetin gauthierpetetin removed the stale Issues that have not had activity in the last 90 days label Nov 14, 2024
Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L enabled auto-merge November 14, 2024 16:30
@Cal-L Cal-L added the No QA Needed Apply this label when your PR does not need any QA effort. label Nov 14, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issues that have not had activity in the last 90 days label Feb 12, 2025
@github-actions github-actions bot removed the stale Issues that have not had activity in the last 90 days label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor No QA Needed Apply this label when your PR does not need any QA effort. team-design-system All issues relating to design system in Mobile
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

8 participants