-
Notifications
You must be signed in to change notification settings - Fork 22
Small improvements to the floki documentation navigation and build/test process #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ilding and testing documentation. Signed-off-by: David Jackson <[email protected]>
… off relevant sections. Because of the theme used (to look like a blog post) the documentation has no clear navigation. This new document helps rectify that without changing the whole theme. Signed-off-by: David Jackson <[email protected]>
- Fix two typos in code - Add syntax to code blocks in documentation and other markdown documents - Add vscode folder to git ignored folders Signed-off-by: David Jackson <[email protected]>
These should help catch common things missed in PRs that mean that e.g. documentation gets out of sync with reality. Signed-off-by: David Jackson <[email protected]>
Signed-off-by: David Jackson <[email protected]>
Signed-off-by: David Jackson <[email protected]>
8ec97e8 to
316c9a6
Compare
|
Hi David, thanks for doing this. One quick nit (I've not looked in detail), vscode related gitignores probably belong in your global gitignore (I do the same for emacs related guff). Editor specifics probably belong out of project codebases, and in your personal configuration instead. Otherwise looks good! Feel free to assign me to do a proper review when you are ready. |
…long in the user's global .gitignore file. Signed-off-by: David Jackson <[email protected]>
|
Thanks for the feedback @rlupton20 - I wasn't previously aware of the global I don't seem to be able to assign the PR to you, but it's ready for review whenever you've got chance to look at it. |
rlupton20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for doing this!
No worries, I didn't know about it for quite a while :-). |
…cs and README updates. Signed-off-by: David Jackson <[email protected]>
|
Thanks for reviewing @rlupton20, I've applied the markup you suggested. I see you've approved the PR, but would you like to re-review? |
|
@daj-code sorry I missed your message - it must have gotten lost in the noise. I already took a look over your new changes - go ahead and merge if you are ready :-). Thanks again for doing this work, and sorry about the long delay in response! |
|
No worries @rlupton20. I don't think I have permission to merge, so would you be able to do so? Thanks! |
|
Yeah, sorry, bloody permissions... |
Why this change?
Navigating the
flokidocumentation is currently non-trivial, as the format of the documentation is a "blog" and therefore has no clear structure or navigation. Instead content is ordered by date created/modified (as set in the page metadata), and the only form of navigation is from theREADME.mdfor the project. Also, to test the documentation after editing it, or to test building it after making changes, is not straightforward and requires you to install the toolhugo.This PR aims to add three key improvements to the floki documentation:
flokidocumentation. This seems like a clear example use case forfloki! Therefore, this is done by adding afloki-hugo.yamlconfig file to the repository to quickly launch a lightweight container where this building and testing of documentation is possible. In particular, this also allows you to quickly launch a hugo server to serve the pages locally, which are then accessible at http://localhost:1313/floki/. The only caveat with this is that it currently uses a much more recent version ofhugothan is currently used in Travis CI to build the published documentation.README.mdand documentation. This allows syntax highlighting when available, which can improve readability of the code blocks. I also added some sections fromREADME.mdto the actual documentation (as they were missing) such as installation viacargobeing possible.I have also added a couple of checks to the PR template to help ensure that documentation is remembered to be kept up to date in future. In addition, I have fixed a few typos/spelling errors I noticed in passing.
Relevant testing
I have tested the documentation by using the new
floki-hugo.yamlconfig to runflokiand then inside that container I ranhugo server -Dto serve the edited documentation at http://localhost:1313/floki/, where I was able to verify the changes that had been made looked as I expected them to. In particular, I verified that the new navigation section always appeared at the top of the documentation homepage, even when the date set in the page metadata was before other pages (and therefore would have appeared lower down the documentation). I also tested that the links in the new navigation page function correctly.Contributor notes
I have added the(REMOVED).vscodefolder to.gitignore, as I use VSCode for editing and having to consistently remember to not include this in commits was cumbersome. If you'd rather keep the.gitignorefile clean of editor-specific artifacts, I am happy to remove this change from the PR.Checks
cargo fmtREADME.mdupdated for this changeCHANGELOG.mdupdated for this change