Remove deprecated async allow/deny #464
Conversation
Meteor 3.1.1 introduce deprecation warnings. collection2 triggered a lot of them. This is due allow/deny async versions being deprecated now. Not sure if this is the best fix, but I think it is a good start and at least it clears the console of those warnings.
|
Right now I can't determine if the tests are wrong or I am missing something in my picture. Any idea @jankapunkt ? |
|
haha sorry @StorytellerCZ I also opened a PR for this #465 LOL didn't see this one. So I did some investigation and it seems this is a bit breaking. We currently have a tight split between sync and async rules, each for the respective counterpart of MongoDB collections. Now we need to have only sync-style names for the allow/deny rules (where one rule represents server AND client and sync AND async somehow). This also assumes there are no Fibers anymore so our backwards compatibility is now definitely broken. We should get in contact with Nacho to get a clear picture of their intention and the background to make an informed decision on how we move on with this |
|
We can also probably do a major version without fibers to lighten things up for those who can go there. |
|
Maybe related: meteor/meteor#13499 |
|
@harryadel @jankapunkt figured out the tests. Had to make a Meteor version test to see if to include them or not to remain backward compatible. Not the most elegant solution, but it works. |
|
sometimes banana-problems require monkey-patching 😆 |
|
Merging, will release as |
Meteor 3.1.1 introduce deprecation warnings.
collection2triggered a lot of them. This is due allow/deny async versions being deprecated now. Not sure if this is the best fix, but I think it is a good start and at least it clears the console of those warnings.