Skip to content

Conversation

@Rageking8
Copy link
Contributor

Fixes #4703

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d06be5a:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 6f18afe:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded
docs/preprocessor/preprocessor-directives.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
File Change Percent This PR contains file(s) with more than 30% file change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c523295:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded
docs/preprocessor/preprocessor-directives.md ✅Succeeded
docs/preprocessor/toc.yml ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@Court72
Copy link
Contributor

Court72 commented Nov 8, 2023

@TylerMSFT

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Nov 8, 2023
Copy link
Collaborator

@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I'll hang onto this but won't send it through now because we don't support this directive yet.

@TylerMSFT
Copy link
Collaborator

@Rageking8, I'm going through PRs and this feature still isn't implemented yet (as of 1/28/2025). I will come back to this once it is. I haven't forgotten it :-)

@v-dirichards
Copy link
Contributor

Closing/reopening to refresh the CLA status

@prmerger-automator
Copy link
Contributor

@Rageking8 : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit c523295:

✅ Validation status: passed

File Status Preview URL Details
docs/preprocessor/hash-error-directive-c-cpp.md ✅Succeeded
docs/preprocessor/hash-warning-directive-c-cpp.md ✅Succeeded
docs/preprocessor/preprocessor-directives.md ✅Succeeded
docs/preprocessor/toc.yml ✅Succeeded

For more details, please refer to the build report.

@prmerger-automator
Copy link
Contributor

PRMerger Results

Issue Description
Added File(s) This PR contains added files. New files require human review.
Yaml File(s) This PR includes changes to .yml file(s) owned by another author.
File Change Percent This PR contains file(s) with more than 30% file change.

@v-dirichards
Copy link
Contributor

v-dirichards commented Sep 2, 2025

Editorial changes LGTM

Copy link
Contributor

@Rastaban Rastaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks good to me.

@TylerMSFT
Copy link
Collaborator

Excellent. I'll port this to the private repo, stage it, and get it published (a procedural thing since we don't add new topics from the public repo)
@Rageking8 - thank you very much for writing this topic up!

@TylerMSFT
Copy link
Collaborator

Closing because I've ported this work to the private repo. I'll publish it from there.
See PR #6119

@TylerMSFT TylerMSFT closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants