-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update permission references and add a note about additional required permissions #10026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: live
Are you sure you want to change the base?
Conversation
@rufer7 : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Learn Build status updates of commit e1c2b07: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
azure-sql/database/authentication-azure-ad-user-assigned-managed-identity.md
Outdated
Show resolved
Hide resolved
Learn Build status updates of commit ee91508: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thanks, @rufer7 - I'm checking on this. |
- [GroupMember.Read.All](/graph/permissions-reference#groupmemberreadall): Allows access to Microsoft Entra group information. | ||
- [Application.Read.All](/graph/permissions-reference#applicationreadalls): Allows access to Microsoft Entra service principal (application) information. | ||
|
||
To create a contained database user for a Microsoft Entra group, the `Group.Read.All` permission is required additionally to the ones listed above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line.
- [GroupMember.Read.All](/graph/permissions-reference#group-permissions): Allows access to Microsoft Entra group information. | ||
- [Application.Read.ALL](/graph/permissions-reference#application-resource-permissions): Allows access to Microsoft Entra service principal (application) information. | ||
- [User.Read.All](/graph/permissions-reference#userreadall): Allows access to Microsoft Entra user information. | ||
- [GroupMember.Read.All](/graph/permissions-reference#groupmemberreadall): Allows access to Microsoft Entra group information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [GroupMember.Read.All](/graph/permissions-reference#groupmemberreadall): Allows access to Microsoft Entra group information. | |
- [Group.Read.All](/graph/permissions-reference#groupreadall): Allows access to contents of Microsoft Entra group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratimDasgupta thanks for the review. Are you sure about the replacement? At least I didn't test without GroupMember.Read.All
permission. In case the replacement is intended, I will also adjust the PoeerShell script in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still working on this, but the idea is to use Group.read.all until GroupMember.Read.All or any other least privilaged api that can support all scenarios. Note: GroupMember.Read.All is a least privilaged api, & thus is a subset of Group.read.all .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratimDasgupta thx for the fast reply. Ah ok, I see. Will GroupMember.Read.All
ever support the scenario outlined in the sentence I added in my PR? Because at least from the name itself it doesn't make sense to allow reading groups by GroupMember.Read.All
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratimDasgupta you can find more context on my use case here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's difficult to say that. Overall, I was trying to consolidate the api(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratimDasgupta I would say least privilege depends on the use case. In the use case I described in the blog post linked in my last comment, assigning Group.Read.All
only would be the least privilege way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rufer7 , just read the blog. Thanks for that, it seems you are using a SMI(Sytem managed identity) & not a UMI(User Managed Identity). Did you try using a UMI & GroupMember.Read.All?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PratimDasgupta yes, exactly I'm using SMI. I prefer SMI over UMI but SMI case is not described in the docs. However the graph permission should not vary from SMI to UMI from my point of view. Otherwise it gets weird as both need to look up the Entra group when creating a user from external identity for a Entra group.
But no, I didn't test it with UMI
This pull request includes changes to the
azure-sql/database/authentication-azure-ad-user-assigned-managed-identity.md
file to update permission references and add a note about additional required permissions for creating a contained database user for a Microsoft Entra group.Permission reference updates:
User.Read.All
,GroupMember.Read.All
, andApplication.Read.All
to correct paths.Additional permissions note:
Group.Read.All
permission is also required for the creation of a contained database user for a Microsoft Entra group.