-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PWA URL Handling] Update URL handling explainer w/ feedback suggestions. #316
Conversation
Nice! I don't think this is a proper resolution of #297. In particular the description field has no processing model, so it should not exist in a specification. |
Do you mean that it is not processed or used? I don't feel very strongly about this. I can remove |
|
How does your implementation intend to use description? |
It is only for human readers, similar to |
If it is not going to impact implementations, then it is best removed from the spec. |
Removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about the addition of allow_all_associations
, and I added an additional comment to #301 to try and discuss that aspect further. You may want to consider removing that specific change from this PR and then merging it out since the rest of it looks good, and then tackle #301 in a separate PR once the discussion there resolves itself.
…iners into users/luhua/feedback_update
Removed "allow_all_associations" field from this PR to allow more discussion on #301. |
As the current changes in this PR are almost entirely URI->URL and JSON formatting changes, and because we would like to migrate this explainer to a WICG repo as soon as possible, I will complete this PR and close the 3 related issues. If the issues should not be resolved, please reopen them in the WICG repo. Thanks. |
Resolves #295, resolves #296, resolves #297.