Extensions API Draft Review #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-risney
requested changes
Apr 24, 2023
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
david-risney
requested changes
May 1, 2023
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
david-risney
requested changes
May 2, 2023
added 2 commits
May 24, 2023 16:01
…and calling remove and set again
david-risney
requested changes
Jun 1, 2023
|
Looking good. After addressing remaining issues, please complete this PR, open a new PR to main, let me know, and I will schedule review. Thanks. |
Co-authored-by: David Risney <[email protected]>
Co-authored-by: David Risney <[email protected]>
dianaqu
added a commit
that referenced
this pull request
Jun 21, 2023
* Extensions API Draft Review (#3409) Extension API Draft Spec Co-authored-by: Diana Qu <[email protected]> Co-authored-by: David Risney <[email protected]> * typo Co-authored-by: Raymond Chen <[email protected]> * No need to capture member variable Co-authored-by: Raymond Chen <[email protected]> * Add noexcept Co-authored-by: Raymond Chen <[email protected]> * sample code change Co-authored-by: Raymond Chen <[email protected]> * add await Co-authored-by: Raymond Chen <[email protected]> * Doc Typo change Co-authored-by: Raymond Chen <[email protected]> * typo Co-authored-by: FrankC-msft <[email protected]> * Fix API review comment * Update more comment --------- Co-authored-by: Diana Qu <[email protected]> Co-authored-by: David Risney <[email protected]> Co-authored-by: Raymond Chen <[email protected]> Co-authored-by: FrankC-msft <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.