New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings when using with single-variant enum #4

Open

dscottboggs wants to merge 1 commit into MihirLuthra:main from dscottboggs:fix/when-only-one-variant

dscottboggs commented Feb 1, 2023

Before this change, when used on an enum with only one variant, cargo would emit the unreachable_pattern warning:

warning: unreachable pattern
 --> entities/src/error.rs:6:5
  |
6 |     #[error("unrecognized visibility '{invalid}'")]
  |     ^
  |
  = note: `#[warn(unreachable_patterns)]` on by default


          Fix warnings when using with single-variant enum

687f360

dscottboggs mentioned this pull request

All the changes wrapped up into one #5

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet