Check starting value instead of computed value #1100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think the example as-written is sort of meant to shift your thinking from "I'll supply inputs to a function" to "I'll supply outputs and a proof to a verifier". So "I know three squared, and here's the proof" is the idea. Perhaps it's so trivial that it doesn't land correctly, but I don't love the fix either. Maybe we should go back to the drawing board on what the hello world is for o1js. |
|
Had a great conversation with @45930 offline. No need to land this change, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought the first example was a little counter-intuitive. You have to perform the computation once with the app and once outside the app to check the result. Now, the app will square the value if you supply the current state.