Skip to content
This repository was archived by the owner on Mar 29, 2024. It is now read-only.

Add webpack into the build process #35

Merged
merged 12 commits into from
Sep 23, 2017
Merged

Add webpack into the build process #35

merged 12 commits into from
Sep 23, 2017

Conversation

ztl8702
Copy link
Member

@ztl8702 ztl8702 commented Sep 3, 2017

As part of #34

@ztl8702 ztl8702 added this to the v2.0 milestone Sep 3, 2017
@ztl8702 ztl8702 requested a review from rovinglight September 3, 2017 13:02
@ztl8702
Copy link
Member Author

ztl8702 commented Sep 3, 2017

臨時 dev build 步驟

gulp serve::dev

Production build is currently broken. I suggest we wait until the migration is finished to fix production builds.

@ztl8702
Copy link
Member Author

ztl8702 commented Sep 3, 2017

現有問題:

點擊播放按鈕無法播放聲音。

Console logs:

Error: t._sounds is undefined
play@http://localhost:3000/all.min.js:3:6950
DetailsCtrl/$scope.playButtonClicked@http://localhost:3000/app.bundle.js:183:21
fn@http://localhost:3000/all.min.js line 1 > Function:4:484
e@http://localhost:3000/all.min.js:1:56716
i@http://localhost:3000/all.min.js:1:129617
$eval@http://localhost:3000/all.min.js:1:66277
$apply@http://localhost:3000/all.min.js:1:66509
compile/</<@http://localhost:3000/all.min.js:1:129667
Vt@http://localhost:3000/all.min.js:1:13671
n@http://localhost:3000/all.min.js:1:13620

Fixed: 這是由於 howlerjs 的API變了。

@ztl8702
Copy link
Member Author

ztl8702 commented Sep 3, 2017

I have added TypeScript to the build process, and it seems to work (can build and serve with gulp serve::dev). Tell me if there are any issues.

@ztl8702 ztl8702 merged commit 7e63e2b into master Sep 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant