Feature/deeper world#25 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Norazan
commented
Feb 26, 2025
| @@ -179,6 +175,25 @@ object DeeperCommands { | |||
| } | |||
| } | |||
| } | |||
| "depth" { | |||
| val playerArg = ArgumentTypes.player() | |||
There was a problem hiding this comment.
I am open to suggestions on how to more easily get a single player or the executor as a player if no player is specified. I'd like to avoid having to deal with a list of players in the executes logic, if possible.
There was a problem hiding this comment.
I believe you have to use a list even for single players in brigadier, slightly annoying but yeah
Boy0000
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes DeeperWorld#25
I'll change MineInAbyss to use the new methods after this PR is merged.