[Wiki Update]: 1.21.2, resources, callouts #4
Conversation
EricristianBros
commented
Nov 2, 2024
EricristianBros
commented
- New resources page (old resources are kept)
- Callouts have been changed to tables and emojis
- 1.21.2 item click food method fix
- Organize misc category
* New resources page (old resources are kept) * Callouts have been changed to tables and emojis * 1.21.2 item click food method fix * Organize misc category
Grammar fixes added escaping to the FAQ, small fixes and consistency in `itemclick` and added a 404 page with a button to go back to the table of contents. Explanation in `questions` about changes to text components.
There was a problem hiding this comment.
Thank you so much for all your hard work trying to keep this wiki up to date and sorry I didn't take the time yet to review all those changes, it always takes hours to go through (which I realize is probably still a lot less than what you invested updating it all, so thank you again!).
In my first review pass I suggested undoing a bunch of grammar stuff I deemed you wrongly corrected, but after looking it up I deleted all those comments again (relating to posessive pronouns s placement and commas after e.g.) as TIL that there are some notable institutions that mandate a comma after an e.g. which was entirely new to me and still feels wrong to read. I was following the way more lenient British style (in which you can even omit the dots in the eg, but that's just weird xD). So in case I didn't delete all those comments again, please just ignore one if you come across it.
Reading these really makes me wish our wiki was built different - maybe in a way where a user can select their minecraft version + edition and we only show them the article contents that is relevant to them (or if only other content is available, show that but with a warning) instead of listing all these different approaches on the same page. Makes it hard to read and annoying to update imo (do you keep this old info? do you put it somewhere out of the way to the bottom of the page? to a different page altogether? uff). Oh well, maybe some day. 😅
I do have a few small change requests and questions before we merge this.
Thank you for taking the initative and changing the notes and warnings to something that will get rendered properly. I also really like the usage of the details elements and the switch to proper code blocks, however i'm not sure py is a good choice when we have mcfunction available. I also think that splitting commands and json blocks to get proper highlighting for both is a must.
(I promise to not sleep on your updates for another few months this time!)
Thank you
Plag
| <details> | ||
| <summary style="color: #e67e22; font-weight: bold;">See example</summary> | ||
|
|
||
| ```json |
There was a problem hiding this comment.
split them up, please. for better highlighting.
| <summary style="color: #e67e22; font-weight: bold;">See example</summary> | ||
|
|
||
| ```json | ||
| # Example storage |
There was a problem hiding this comment.
there are a few of those in this file that should be split up
| tellraw @a[tag=buyer.netherite,scores={diamonds=5..}] {"text":"You bought a netherite ingot for 5 diamonds","color":"green"} | ||
| tellraw @a[tag=buyer.netherite,scores={diamonds=..4}] {"text":"You don't have 5 diamonds","color":"dark_red"} | ||
| tag @a remove buyer.netherite | ||
| # Command blocks |
There was a problem hiding this comment.
you seem to have forgotten the code block
|
|
||
| In 1.20.5 `execute if items` was added, which allows to count items in a diferent way. | ||
| To use this method, all command remains the same, as the previus example except the one for counting items that is this one: | ||
|
|
||
| execute as @a[tag=buyer.netherite] store result score @s diamonds run clear @s diamond 0 |
There was a problem hiding this comment.
needs code blocks here and in the next few lines as well
| | 📝 Note | | ||
| |--------------| | ||
| |in order for it to work with npc, change `@p` and `@a` to `@initiator`| | ||
| |_Related: [How to setup a NPC?](wiki/questions/npc)_| |
There was a problem hiding this comment.
| |_Related: [How to setup a NPC?](wiki/questions/npc)_| | |
| |_Related: [How to setup a NPC?](/wiki/questions/npc)_| |
probably broken link
