(WIP) ModLauncher 11 #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reuse the same `OptionParser` and default `OptionSpec`s - Feed args directly into the constructor - Store DiscoveryData instance in one place, use it as a cache for things like `getSpecialJars()` and `getLaunchTarget()`
The `ServiceRunner` was always immediately called after being retrieved, so calling directly rather than forcing indirection through a `ServiceRunner` is simpler. The `TestingLaunchHandlerService` continues calling `public static ServiceRunner supplier()`, but now uses `invokeExact()` instead of `invoke()`
…lizeLaunch(ITransformerLoader, NamedPath[])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft PR proposes some breaking changes in order to further clean-up and simplify ModLauncher.
Main changes:
Open questions:
ServiceRunneruntil the ModLauncher 12 rewrite?ServiceRunnerwas always immediately called after being retrieved, so calling directly rather than forcing indirection through aServiceRunneris simpler. But this is a wide-reaching breaking change that is likely to break again in the ModLauncher 12 rewrite anyway.ILaunchHandlerServicehave added to it? Forge's usages says it needs more things, but doesn't say what exactlyModuleLayerHandlerto static init inside the Launcher main class? This would remove the need for passing a lot of objects around everywhere internally (both theModuleLayerHandleritself and things that rely on it), which in turn could simplify things much furtherProtectionDomainHelperbe removed?logpackage be removed?Still to do:
TransformTargetLabel.LabelTypeandITransformer.TargetTypeIterable