Add new test harness artifact and fix tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Launcher not getting correct version information when not in a SecureModuleClassLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paint's recent cleanup caused NPE's in the old test setup. Which made the old tests not run.
So fixed Launcher not getting correct version information when not in a SecureModuleClassLoader
I changed the root project name to be "modlauncher" to match the casing we publish the artifact as, just for consistancy.
Functionally that's the only change for ModLauncher itself, besides one cleanup in TransfromerList.
I created a new test harness artifact 'net.minecraftforge:modlauncher-harness' which should simplify the existing test structure in other projects that need to work with transformed states. It also has a couple of small helper classes aimed at test makers.
I have also cleaned up/re-written all the tests to use this new harness so there are plenty of examples.
Removed a bunch of tests that actually weren't testing anything.
It's basically an enhanced version of my CoreMods test framework published as a reusable artifact.
This did show me a lot of gradle and other cleanups that could be done on this project but that is not the point of this PR.
Also, ideally this would be a subproject build using the new system @Jonathing has been working on. So that the harness gets its own version number.