Refactor codebase per Go patterns review#4
Merged
gali-leilei merged 3 commits intomainfrom Mar 11, 2026
Merged
Conversation
Deduplicate Run/RunWithDB, consolidate parseRanks/parseCSVInts, extract IN-clause helper, add symbol.Entry named type, accept store.Metadata struct in InsertMetadata, add store.Open for read-only paths, and return errors from parseCSVInts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run/RunWithDB—Runnow delegates toRunWithDBafter creating the DBparseRanks/parseCSVInts— single function returning([]int, error)instead oflog.Fatalfsymbol.Entrytype — replaces anonymousstruct{ ID int; Name string }inTable.All()inClausehelper — removes 8 copies of the IN-clause builder pattern inreader.goInsertMetadatatakesstore.Metadatastruct — replaces 8 positional parametersstore.Openfor read paths — read-optimised DB open without WAL/synchronous pragmasparseCSVIntsreturns error — utility functions no longer calllog.FatalfCloses #3
Test plan
go vet ./...passesgo build ./...passesgo test ./... -short— all packages pass🤖 Generated with Claude Code