security: replace eval/compile with importlib for loading dvm_permissions.py#2609
Closed
mitre88 wants to merge 2 commits into
Closed
security: replace eval/compile with importlib for loading dvm_permissions.py#2609mitre88 wants to merge 2 commits into
mitre88 wants to merge 2 commits into
Conversation
added 2 commits
April 23, 2026 11:07
- Replace deprecated yaml.load() with yaml.safe_load() to prevent arbitrary code execution - Add error logging to bare except Exception clause for better debugging
…ions.py - Replace dangerous eval(compile(open(...).read(), ...)) pattern with safe importlib module loading - Use importlib.util.spec_from_file_location and module_from_spec to properly import the Python file - Eliminates risk of arbitrary code execution
Member
|
Thanks for the PR. I will get back after testing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace dangerous
eval(compile(open(...).read(), ...))pattern with safeimportlibmodule loading.Changes
scripts/update_android_permissions.py: Useimportlib.util.spec_from_file_locationandmodule_from_specto properly import the Python file instead of eval/compileWhy
Using
eval()andcompile()to execute code read from a file is a significant security risk. Even though this is a development script, usingimportlibis the proper, safe way to dynamically load Python modules.