Open
Conversation
|
Board and firmware folder for this pull request: |
|
Thank you! Community device authors will be pleased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When connecting to AVR boards with DTR enabled, these boards get resettet on connect. After resetting the boards respond at least with
17,OK;(not processed from the connector). Other board types which are used for community devices might also respond with additional messages which could lead to an unrecognized board or set them into bootlaoder mode (could happen for some ESP32 boards).This PR disables setting DTR line on connect for all boards except for ProMicro which requires setting the DTR line.
See also PR #2870 and issue #2849 in the connector repo.