Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-16967] Allow writing ArrayType(TimestampType) to Clickhouse #14

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 2, 2024

Change Summary

  • There was a bug in matching against DateTime Clickhouse type. After applying a fix, users can write ArrayType(TimestampType()) columns from Spark to Clickhouse.
  • Fixed issue with writing ArrayType(ShortType()) to Clickhouse, by changing type name to case-insensitive alias.
  • Added negative test for reading some array types from Clickhouse to Spark.
  • Fix type mapping table, Spark actually could create tables with Array columns. Also there were missing rows for Date and Array(Int32) column types.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • My PR is ready to review.

@dolfinus dolfinus requested a review from maxim-lixakov October 2, 2024 12:44
@dolfinus dolfinus self-assigned this Oct 2, 2024
@dolfinus dolfinus changed the title [DOP-16967] Allow writing ArrayType(TimestampType) from Spark to Clic… [DOP-16967] Allow writing ArrayType(TimestampType) to Clickhouse Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.39%. Comparing base (5d72653) to head (bcdf700).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...lickhouse/spark35/ClickhouseDialectExtension.scala 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #14      +/-   ##
===========================================
+ Coverage    71.55%   73.39%   +1.83%     
===========================================
  Files            2        2              
  Lines          109      109              
  Branches        27       27              
===========================================
+ Hits            78       80       +2     
+ Misses          21       19       -2     
  Partials        10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dolfinus dolfinus merged commit 646aeb8 into develop Oct 2, 2024
4 checks passed
@dolfinus dolfinus deleted the feature/DOP-16967 branch October 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants