Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitpack for v4.1.0 is broken #1473

Closed
esuomi opened this issue Jun 2, 2023 · 4 comments
Closed

Jitpack for v4.1.0 is broken #1473

esuomi opened this issue Jun 2, 2023 · 4 comments
Assignees
Labels
bug Something isn't working (crash, a rule has a problem)

Comments

@esuomi
Copy link

esuomi commented Jun 2, 2023

Describe the bug

See jitpackProblem.txt
Note the original post gave this link: https://jitpack.io/com/github/MobilityData/gtfs-validator/v4.1.0/build.log this log was overwritten by a successful build since then. See the above attached file instead.

Looking at Jitpack's logs, the two main issues are missing documentation for various params and return values and no test artifacts, which together cause the build to fail in such way that nothing is published.

Steps/Code to Reproduce

Expected Results

Working build so that I could use gtfs-validator's latest&greatest as Maven dependency.

Actual Results

No artifact available.

Screenshots

No response

Files used

No response

Validator version

4.1.0

Operating system

unrelated

Java version

No response

Additional notes

No response

@esuomi esuomi added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels Jun 2, 2023
@welcome
Copy link

welcome bot commented Jun 2, 2023

Thanks for opening your first issue in this project! If you haven't already, you can join our slack and join the #gtfs-validators channel to meet our awesome community. Come say hi 👋!

Welcome to the community and thank you for your engagement in open source! 🎉

@miles-grant-ibigroup
Copy link

We are facing the same issue, and are also unable to upgrade the package version as a result

@jcpitre jcpitre self-assigned this Sep 18, 2023
@jcpitre
Copy link
Contributor

jcpitre commented Sep 21, 2023

Removed the failed build on jitpack (https://jitpack.io/#MobilityData/gtfs-validator) then did a build on a local test project and jitback rebuilt it with no error. It should now be available.

As to why it failed before and not now, I have some theories:

Execution failed for task ':aggregateJavadocJar'.
Could not add file '/home/jitpack/build/build/docs/aggregateJavadoc/gtfs-validator-4.1.0-javadoc.jar' to ZIP '/home/jitpack/build/build/docs/aggregateJavadoc/gtfs-validator-4.1.0-javadoc.jar'.

i.e. it was trying to add a jar file to itself. This fits with the bug.

  • There was a change done in freefair that could have solved the problem, although I am not sure it affected the version we use: freefair/gradle-plugins@1ac0180

  • Another possibility is that jitpack changed something in the way they build. In particular it seems that the freefair bug occurs on some linux distros, but not others. Maybe they changed the distro they use for building? Or some other change on their end.

  • on the gtfs-validator side, it's building from v4.1.0 tag, so there was no change that could explain why it was broken but not anymore.

@jcpitre jcpitre closed this as completed Sep 21, 2023
@jcpitre
Copy link
Contributor

jcpitre commented Sep 21, 2023

For reference I attached the log of the failed build here, since it was overwritten when the new successful build was done.
jitpackProblem.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem)
Projects
None yet
Development

No branches or pull requests

3 participants