Feat/compare page #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoooec
approved these changes
Jun 17, 2024
| @@ -1,7 +1,7 @@ | |||
| import React, { useState, useEffect, ChangeEvent, KeyboardEvent } from "react"; | |||
| import { Compare } from "@/components/Chip/Compare/Compare"; | |||
| import styles from "./CompareInput.module.scss"; | |||
| import { dummyProducts, Product } from "./compareProductMock"; | |||
| import { Product } from "./compareProductMock"; | |||
There was a problem hiding this comment.
Mock 파일을 이제 더이상 사용 안하니까 별도의 type 파일 이용하시는게 좋을 것 같아요!
글로벌 선언된 타입에 프로덕트 있는것같은데 그거 사용하시는건 어떨까용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
�검색 / 비교하기 완성..?
Changes Made
Screenshots
IssueNumber
[#28 ]