This repository was archived by the owner on May 19, 2022. It is now read-only.
A few fixes to turfs. #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes:
Mojave-Sun/tg-ashcloud#94
Mojave-Sun/tg-ashcloud#90
Previously prying up tiles and replacing them lead to an error from a mismatched
iconvar due to shitty turf code from upstream. This solves that by creating a /f13 tile item, but unfortunately leaves us where old Fallout 13 was; with no way for players to replace the exact floor tile type they pried up. I will work on that part of the problem again in the future.This also solves explosions causing missing icon_states because we don't have the icon_ states needed for it and we have no chance of ever making that many..
Currently it just disables any visual cue of a tile being damaged, but I'm hoping to stick an overlay in here instead soon, possibly before this PR gets merged.
Lastly, destroyed turfs on the ground floor now create mountain floor, instead of openspace.
...Not really sure why we ever thought that was a good idea.
Why It's Good For The Game
Needed to take care of these before we do a public test.