fix CI & drop EoL MongoDB < 4.4 #2887
Merged
+73
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
fix-ci
branch
6 times, most recently
from
acf3f9a to
6a72192
Compare
terencehonles
commented
May 28, 2025
.github/workflows/install_mongo.sh
Outdated
| if [[ "${MONGODB}" =~ ^(7.0|8.0) ]]; then | ||
| if [[ "$MONGODB" =~ ^(6.0|7.0|8.0) ]]; then | ||
| mongo_build="mongodb-linux-x86_64-ubuntu2204-${MONGODB}" | ||
| elif [[ "$MONGODB" =~ ^(4.4|5.0) ]]; then | ||
| mongo_build="mongodb-linux-x86_64-ubuntu2004-${MONGODB}" |
There was a problem hiding this comment.
like before, this still seems to work on 22.04, so I'm not going to try fixing/changing this
|
@bagerard can this PR be merged? The CI is currently broken, preventing other contributions from being made. |
|
Thanks for the contribution, highly appreciated. Sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the CI by updating the ubuntu runner and drops EoL MongoDB versions below 4.4 which cannot be easily installed on Ubuntu 22.04.