quick fix for the raised issue #12208 regarding the functions of io.imsave() and io.save_rois()#1211
Open
Jiadalee wants to merge 2 commits intoMouseLand:mainfrom
Open
quick fix for the raised issue #12208 regarding the functions of io.imsave() and io.save_rois()#1211Jiadalee wants to merge 2 commits intoMouseLand:mainfrom
Jiadalee wants to merge 2 commits intoMouseLand:mainfrom
Conversation
Jiadalee
commented
May 29, 2025
Author
Jiadalee
left a comment
Jiadalee
left a comment
There was a problem hiding this comment.
pls skip the first four commits under this pr, since they are not useful. Pls only consider the commit of Quick fix for issue1208 TypeError: imsave() and io.save_rois()
Collaborator
|
@Jiadalee there's no way for me to 'skip' commits. Instead, you'll need to edit the commit history on your repo, push them to your branch, and this PR will update. |
Jiadalee
force-pushed
the
main
branch
2 times, most recently
from
f86c5eb to
d0df00c
Compare
Author
|
@mrariden I cleaned my repo and re-push the exact 2 commits for this pr. Feel free to review them. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At run_Cellpose-SAM.ipynb file, both io.imsave() and io.save_rois() should not return anything since the API specifies that these two functions return None. Also, the
mask[i]is missing in the io.imsave() function. With that, I updated those codes to save images and rois in a proper way.