fix: remove black stripe artefacts when axis != -1 in#1270
Open
spkgyk wants to merge 2 commits intoMouseLand:mainfrom
Open
fix: remove black stripe artefacts when axis != -1 in#1270spkgyk wants to merge 2 commits intoMouseLand:mainfrom
spkgyk wants to merge 2 commits intoMouseLand:mainfrom
Conversation
Collaborator
|
Looks good. What were the settings/image dimensions that produced the error? |
Author
|
It happens when you pass in paths to the evaluation method. It loads the images, makes them channels first, and requests the normalisation function with axis=0. It happens whenever axis!=-1 I think. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 48.96% 48.89% -0.07%
==========================================
Files 16 16
Lines 3762 3767 +5
==========================================
Hits 1842 1842
- Misses 1920 1925 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Will this be merged? Not trying to rush, just curious about the release schedule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clean-up loop that sets un-normalised channels to 0 expected the channel dimension to be last. However, since
np.moveaxis(..., -1, axis)was done prior to this, instead of setting the channel to zero, it would set a row/column (depending on the axis) to zero instead, resulting in a black bar across the image.