Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In using the gui, I tried to drag an nd2 file and got this error:
that error is primarily due to exceptions simply being printed, but not stopping the function here:
cellpose/cellpose/gui/io.py
Lines 132 to 141 in 4fbdc7c
but the underlying cause was that nd2 files aren't hooked up in
imreadcellpose/cellpose/io.py
Lines 188 to 191 in 4fbdc7c
so, even if nd2 is available, the function returns None. This fixes both.
Note: the intended semantics for the return value of
imreadwasn't entirely clear to me (i.e. what expectations are made about the dimensionality and shape of the value returned by imread?) ... so I took a best guess from the other code. Let me know if i should be returning something different