Skip to content

ps3: Surfaces #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Fancy2209 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

ps3: Surfaces #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4122be2
ps3: Surfaces
Fancy2209 May 15, 2026
83215f3
ps3gl: Fix glReadPixels flipping twice
Fancy2209 May 15, 2026
0d01188
glLegacyRenderer: add glDrawRectangleColor
Fancy2209 May 15, 2026
935c2e8
Attach a depth buffer for created framebuffers
MrPowerGamerBR May 16, 2026
eb04bac
Fix glReadPixels to unflip the textures
MrPowerGamerBR May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
cmake_minimum_required(VERSION 3.21)

if(PLATFORM STREQUAL "ps3")
set(CMAKE_TOOLCHAIN_FILE ${CMAKE_SOURCE_DIR}/cmake/ppu.cmake)
endif()

project(butterscotch C)

set(CMAKE_C_STANDARD 99)
Expand Down
153 changes: 62 additions & 91 deletions src/gl_legacy/gl_legacy_renderer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,36 +41,10 @@ extern GLint gPalettedUPaletteVLoc;
#include "stb_ds.h"
#include "utils.h"
#include "image_decoder.h"
#ifndef PLATFORM_PS3
#include "gl_common.h"
#endif

// ===[ Helpers ]===

#ifdef PLATFORM_PS3
static void glApplyViewport(GLLegacyRenderer* gl, int32_t x, int32_t y, int32_t w, int32_t h) {
int32_t effW, effH;
if ((gl->gameW * gl->windowH) / gl->gameH < gl->windowW) {
effW = (gl->gameW * gl->windowH) / gl->gameH;
effH = gl->windowH;
} else {
effW = gl->windowW;
effH = (gl->gameH * gl->windowW) / gl->gameW;
}
float scale = (float)effW / (float)gl->gameW;
int32_t offsetX = (gl->windowW - effW) / 2;
int32_t offsetY = (gl->windowH - effH) / 2;

int32_t vpX = offsetX + (int32_t)(x * scale);
int32_t vpY = offsetY + (int32_t)((gl->gameH - y - h) * scale);
int32_t vpW = (int32_t)(w * scale);
int32_t vpH = (int32_t)(h * scale);

glViewport(vpX, vpY, vpW, vpH);
glEnable(GL_SCISSOR_TEST);
glScissor(vpX, vpY, vpW, vpH);
}
#else
static void glApplyViewport(GLLegacyRenderer* gl, int32_t x, int32_t y, int32_t w, int32_t h) {
int32_t glY = gl->gameH - y - h;
glViewport(x, glY, w, h);
Expand All @@ -82,7 +56,6 @@ static void glApplyViewport(GLLegacyRenderer* gl, int32_t x, int32_t y, int32_t
gl->base.CPortW = w;
gl->base.CPortH = h;
}
#endif

// ===[ Vtable Implementations ]===

Expand Down Expand Up @@ -133,7 +106,6 @@ static void glInit(Renderer* renderer, DataWin* dataWin) {
gl->originalTpagCount = dataWin->tpag.count;
gl->originalSpriteCount = dataWin->sprt.count;

#ifndef PLATFORM_PS3
// Create FBO
glGenFramebuffers(1, &gl->fbo);
gl->fboTexture = 0;
Expand All @@ -145,7 +117,6 @@ static void glInit(Renderer* renderer, DataWin* dataWin) {
gl->surfaceWidth = nullptr;
gl->surfaceHeight = nullptr;
gl->surfaceCount = 0;
#endif

fprintf(stderr, "GL: Renderer initialized (%u texture pages)\n", gl->textureCount);
}
Expand All @@ -157,7 +128,6 @@ static void glDestroy(Renderer* renderer) {

glDeleteTextures((GLsizei) gl->textureCount, gl->glTextures);

#ifndef PLATFORM_PS3
if (gl->fboTexture != 0) glDeleteTextures(1, &gl->fboTexture);
if (gl->fbo != 0) glDeleteFramebuffers(1, &gl->fbo);
for (uint32_t i = 0; gl->surfaceCount > i; i++) {
Expand All @@ -168,7 +138,6 @@ static void glDestroy(Renderer* renderer) {
free(gl->surfaceTexture);
free(gl->surfaceWidth);
free(gl->surfaceHeight);
#endif

free(gl->glTextures);
free(gl->textureWidths);
Expand All @@ -184,7 +153,6 @@ static void glBeginFrame(Renderer* renderer, int32_t gameW, int32_t gameH, int32
gl->gameW = gameW;
gl->gameH = gameH;

#ifndef PLATFORM_PS3
if (gameW != gl->fboWidth || gameH != gl->fboHeight) {
GLCommon_resizeMainFBO(&gl->fboTexture, gl->fbo, &gl->fboWidth, &gl->fboHeight, gameW, gameH);
}
Expand All @@ -195,9 +163,6 @@ static void glBeginFrame(Renderer* renderer, int32_t gameW, int32_t gameH, int32
gl->base.CPortY = 0;
gl->base.CPortW = gameW;
gl->base.CPortH = gameH;
#else
glApplyViewport(gl, 0, 0, gameW, gameH);
#endif
glBindTexture(GL_TEXTURE_2D, 0);
}

Expand Down Expand Up @@ -268,10 +233,8 @@ static void glEndGUI(MAYBE_UNUSED Renderer* renderer) {
}

static void glEndFrame(Renderer* renderer) {
MAYBE_UNUSED GLLegacyRenderer* gl = (GLLegacyRenderer*) renderer;
#ifndef PLATFORM_PS3
GLLegacyRenderer* gl = (GLLegacyRenderer*) renderer;
GLCommon_letterboxBlit(gl->fbo, gl->fboWidth, gl->fboHeight, gl->gameW, gl->gameH, gl->windowW, gl->windowH);
#endif
}

static void glRendererFlush(MAYBE_UNUSED Renderer* renderer) {}
Expand Down Expand Up @@ -654,9 +617,61 @@ static void glDrawRectangle(Renderer* renderer, float x1, float y1, float x2, fl
}
}

static void glDrawRectangleColor(Renderer* renderer, float x1, float y1, float x2, float y2, uint32_t color1, MAYBE_UNUSED uint32_t color2, MAYBE_UNUSED uint32_t color3, MAYBE_UNUSED uint32_t color4, float alpha, bool outline) {
// Stub! Please implement me later. :3
glDrawRectangle(renderer, x1, y1, x2, y2, color1, alpha, outline);
static void glDrawLineColor(Renderer* renderer, float x1, float y1, float x2, float y2, float width, uint32_t color1, uint32_t color2, float alpha);
static void glDrawRectangleColor(Renderer* renderer, float x1, float y1, float x2, float y2, uint32_t color1, uint32_t color2, uint32_t color3, uint32_t color4, float alpha, bool outline) {
GLLegacyRenderer* gl = (GLLegacyRenderer*) renderer;

float r1 = (float) BGR_R(color1) / 255.0f;
float g1 = (float) BGR_G(color1) / 255.0f;
float b1 = (float) BGR_B(color1) / 255.0f;

float r2 = (float) BGR_R(color2) / 255.0f;
float g2 = (float) BGR_G(color2) / 255.0f;
float b2 = (float) BGR_B(color2) / 255.0f;

float r3 = (float) BGR_R(color3) / 255.0f;
float g3 = (float) BGR_G(color3) / 255.0f;
float b3 = (float) BGR_B(color3) / 255.0f;

float r4 = (float) BGR_R(color4) / 255.0f;
float g4 = (float) BGR_G(color4) / 255.0f;
float b4 = (float) BGR_B(color4) / 255.0f;

glBindTexture(GL_TEXTURE_2D, gl->whiteTexture);

if (outline) {
// Draw 4 one-pixel-wide edges: top, bottom, left, right
glDrawLineColor(renderer, x1, y1, x2, y1, 1.0, color1, color2, alpha);
glDrawLineColor(renderer, x2, y1, x2, y2, 1.0, color2, color3, alpha);
glDrawLineColor(renderer, x2, y2, x1, y2, 1.0, color3, color4, alpha);
glDrawLineColor(renderer, x1, y2, x1, y1, 1.0, color4, color1, alpha);
} else {
// Filled rectangle: GML adds +1 to width/height for filled rects

// All UVs point to (0.5, 0.5) center of the 1x1 white texture
glBegin(GL_QUADS);
// Vertex 0: top-left
glColor4f(r1, g1, b1, alpha);
glTexCoord2f(0.5f, 0.5f);
glVertex2f(x1, y1);

// Vertex 1: top-right
glColor4f(r2, g2, b2, alpha);
glTexCoord2f(0.5f, 0.5f);
glVertex2f(x2+1, y1);

// Vertex 2: bottom-right
glColor4f(r3, g3, b3, alpha);
glTexCoord2f(0.5f, 0.5f);
glVertex2f(x2+1, y2+1);

// Vertex 3: bottom-left
glColor4f(r4, g4, b4, alpha);
glTexCoord2f(0.5f, 0.5f);
glVertex2f(x1, y2+1);

glEnd();
}
}

// ===[ Line Drawing ]===
Expand Down Expand Up @@ -1192,7 +1207,6 @@ static int32_t glCreateSpriteFromSurface(Renderer* renderer, int32_t surfaceID,

if (0 >= w || 0 >= h) return -1;

#ifndef PLATFORM_PS3
// Bind the source FBO and figure out its height for the GL bottom-up flip.
// application_surface (-1) reads from the main FBO; otherwise read from the matching surface FBO.
int32_t srcHeight;
Expand All @@ -1205,40 +1219,12 @@ static int32_t glCreateSpriteFromSurface(Renderer* renderer, int32_t surfaceID,
glBindFramebuffer(GL_READ_FRAMEBUFFER, gl->surfaces[surfaceID]);
srcHeight = gl->surfaceHeight[surfaceID];
}
#endif

uint8_t* pixels = safeMalloc((size_t) w * (size_t) h * 4);
if (pixels == nullptr)
return -1;

#ifdef PLATFORM_PS3
if (0 > x || 0 > y || (uint32_t) (x + w) > display_width || (uint32_t) (y + h) > display_height) {
free(pixels);
return -1;
}
// Ensure that the draw calls were executed
waitFinish();
const uint8_t* src = (const uint8_t*) color_buffer[curr_fb];
size_t srcRowBytes = color_pitch;
size_t dstRowBytes = (size_t) w * 4;
repeat(h, row) {
const uint8_t* srcLine = src + ((size_t) (y + row)) * srcRowBytes + (size_t) (x * 4);
uint8_t* dstLine = pixels + (size_t) row * dstRowBytes;
repeat(w, px) {
// Swizzle from ARGB to RGBA
uint8_t a = srcLine[px * 4 + 0];
uint8_t r = srcLine[px * 4 + 1];
uint8_t g = srcLine[px * 4 + 2];
uint8_t b = srcLine[px * 4 + 3];
dstLine[px * 4 + 0] = r;
dstLine[px * 4 + 1] = g;
dstLine[px * 4 + 2] = b;
dstLine[px * 4 + 3] = a;
}
}
// We don't need to flip vertically because the PlayStation 3 framebuffer is already top-down
#else
// OpenGL Y is bottom-up, GML Y is top-down, so flip the Y coordinate against the source FBO's height
// OpenGL Y is bottom-up, GML Y is top-down, so flip the Y coordinate
int32_t glY = srcHeight - y - h;
glReadPixels(x, glY, w, h, GL_RGBA, GL_UNSIGNED_BYTE, pixels);

Expand All @@ -1253,7 +1239,6 @@ static int32_t glCreateSpriteFromSurface(Renderer* renderer, int32_t surfaceID,
memcpy(bot, rowTemp, rowBytes);
}
free(rowTemp);
#endif

// Create a new GL texture from the captured pixels
GLuint newTexId;
Expand Down Expand Up @@ -1390,8 +1375,6 @@ static void glGpuGetColorWriteEnable(Renderer* renderer, bool* red, bool* green,

// ===[ Surfaces ]===

#ifndef PLATFORM_PS3

static int32_t glLegacyCreateSurface(Renderer* renderer, int32_t width, int32_t height) {
GLLegacyRenderer* gl = (GLLegacyRenderer*) renderer;
uint32_t surfaceIndex = GLCommon_findOrAllocateSurfaceSlot(&gl->surfaces, &gl->surfaceTexture, &gl->surfaceWidth, &gl->surfaceHeight, &gl->surfaceCount);
Expand Down Expand Up @@ -1544,8 +1527,13 @@ static void glLegacyDrawSurface(Renderer* renderer, int32_t surfaceId, int32_t s
// top-down GML coords -> flipped V for our bottom-up texture
float u0 = (float) srcLeft / (float) texW;
float u1 = (float) (srcLeft + srcWidth) / (float) texW;
#ifndef PLATFORM_PS3
float v0 = 1.0f - (float) srcTop / (float) texH;
float v1 = 1.0f - (float) (srcTop + srcHeight) / (float) texH;
#else
float v1 = 1.0f - (float) srcTop / (float) texH;
float v0 = 1.0f - (float) (srcTop + srcHeight) / (float) texH;
#endif

float r = (float) BGR_R(color) / 255.0f;
float g = (float) BGR_G(color) / 255.0f;
Expand Down Expand Up @@ -1580,23 +1568,6 @@ static bool glLegacySurfaceGetPixels(Renderer* renderer, int32_t surfaceId, uint
return GLCommon_surfaceGetPixels(gl->surfaces, gl->surfaceWidth, gl->surfaceHeight, gl->surfaceCount, surfaceId, outRGBA);
}

#else

// TODO: Add support for surfaces in ps3gl!

static int32_t glLegacyCreateSurface(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t width, MAYBE_UNUSED int32_t height) { return -1; }
static bool glLegacySurfaceExists(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID) { return false; }
static bool glLegacySetRenderTarget(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID) { return false; }
static float glLegacyGetSurfaceWidth(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID) { return 0.0f; }
static float glLegacyGetSurfaceHeight(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID) { return 0.0f; }
static void glLegacyDrawSurface(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID, MAYBE_UNUSED int32_t srcLeft, MAYBE_UNUSED int32_t srcTop, MAYBE_UNUSED int32_t srcWidth, MAYBE_UNUSED int32_t srcHeight, MAYBE_UNUSED float x, MAYBE_UNUSED float y, MAYBE_UNUSED float xscale, MAYBE_UNUSED float yscale, MAYBE_UNUSED float angleDeg, MAYBE_UNUSED uint32_t color, MAYBE_UNUSED float alpha) {}
static void glLegacySurfaceResize(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID, MAYBE_UNUSED int32_t width, MAYBE_UNUSED int32_t height) {}
static void glLegacySurfaceFree(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID) {}
static void glLegacySurfaceCopy(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t DestSurfaceID, MAYBE_UNUSED int32_t DestX, MAYBE_UNUSED int32_t DestY, MAYBE_UNUSED int32_t SrcSurfaceID, MAYBE_UNUSED int32_t SrcX, MAYBE_UNUSED int32_t SrcY, MAYBE_UNUSED int32_t SrcW, MAYBE_UNUSED int32_t SrcH, MAYBE_UNUSED bool part) {}
static bool glLegacySurfaceGetPixels(MAYBE_UNUSED Renderer* renderer, MAYBE_UNUSED int32_t surfaceID, MAYBE_UNUSED uint8_t* outRGBA) { return false; }

#endif


// ===[ Vtable ]===

Expand Down
2 changes: 0 additions & 2 deletions src/gl_legacy/gl_legacy_renderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ typedef struct {

bool colorWriteR, colorWriteG, colorWriteB, colorWriteA;

#ifndef PLATFORM_PS3
// FBO for render-to-texture (game renders here, then blitted to screen)
GLuint fbo;
GLuint fboTexture;
Expand All @@ -48,7 +47,6 @@ typedef struct {
int32_t* surfaceWidth;
int32_t* surfaceHeight;
uint32_t surfaceCount;
#endif
} GLLegacyRenderer;

Renderer* GLLegacyRenderer_create(void);
1 change: 1 addition & 0 deletions vendor/ps3gl/GL/ps3gl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#pragma once

#define GL_GLEXT_PROTOTYPES
#include "GL/gl.h"
#ifdef __cplusplus
extern "C"
Expand Down
Loading
Loading