This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Sync scorer data in the background #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
background-scorer-sync
branch
from
8e46996 to
c3a3c05
Compare
benthecarman
force-pushed
the
background-scorer-sync
branch
from
c3a3c05 to
c7a3e12
Compare
benthecarman
commented
Feb 6, 2024
Comment on lines
-581
to
-585
| // If we are stopped, don't sync | ||
| if nm.stop.load(Ordering::Relaxed) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
removed this check because we just do it again immediately once we enter the loop anyways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to sync scorer in the background rather than upfront, this made the startup ~500ms faster for me. This will still read the scorer on start up so we will still have a scorer up until it is synced.
#1016