Skip to content
This repository was archived by the owner on Feb 3, 2025. It is now read-only.

Add on chain for federations #1146

Merged
merged 8 commits into from
May 9, 2024
Merged

Add on chain for federations #1146

merged 8 commits into from
May 9, 2024

Conversation

AnthonyRonning
Copy link
Contributor

@AnthonyRonning AnthonyRonning commented Apr 17, 2024

TODO:

  • Withdrawals
  • Frontend needs to allow withdrawals from fedimint balance
  • Change APIs to account for withdraw pending
  • Figure out max send situation
  • Monitor eventual TXID for confirmations (fedimint doesn't care about tracking it)
  • Lots of TODOs in the on chain cleanup in federation.rs
  • pull activity list for on chain addresses
  • Refreshing doesn't show on chain history
  • activity item for on chain deposit doesn't show additional info
  • tests for activity item & indexing
  • subscribe to pending on chain operations
  • show payment details on the onchain send screen when the link is clicked
  • handle tiny amounts properly if they are attempted to be paid

@AnthonyRonning
Copy link
Contributor Author

This works as long as you don't try to send max. Still a lot of code to clean up and want to do some tests.

There's some possible ideas for frontend changes too but will think about them more.

  • we should say not to send more than once to the address
  • we should tell them it requires 10 confs for deposits
  • we should probably show a fee to confirm before sending

@AnthonyRonning AnthonyRonning force-pushed the federation-onchain branch 3 times, most recently from da05793 to 1bb5972 Compare May 8, 2024 03:17
@AnthonyRonning
Copy link
Contributor Author

I want to do some tests for the activity item stuff but this is ready for review

@AnthonyRonning AnthonyRonning marked this pull request as ready for review May 8, 2024 04:20
Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good

@AnthonyRonning AnthonyRonning force-pushed the federation-onchain branch 3 times, most recently from 518c376 to 55a91a1 Compare May 8, 2024 17:53
@AnthonyRonning
Copy link
Contributor Author

READY

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small things, otherwise LGTM, nice job

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@AnthonyRonning AnthonyRonning merged commit 2c18ebe into master May 9, 2024
9 checks passed
@AnthonyRonning AnthonyRonning deleted the federation-onchain branch May 9, 2024 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants