This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Set preimage for fedimint invoices #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
works now |
AnthonyRonning
approved these changes
Jun 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1227
Was talking to @gudnuf and he was getting responses, but the preimage was not set after it was paid. It seems like for fedimints we never set the preimage for invoices we create, first commit will make sure we save it to the invoice. Needed to add the second commit so we don't overwrite the preimage on the payment actually being completed, before we'd just recreate the MutinyInvoice instead of editing the one we had persisted. I believe the 2nd commit might help fix some issues where the same invoice would show up multiple times in the activity as well