This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
fix: estimate_ln_fee should be in sats
#1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estimate_ln_fee should always return amount in sats not msats. This is not what happens when we get the amount from the Bolt11 invoice.
|
Do you guys want me to add a test to this PR? So that this does not happen again on |
|
Adding a test would be great, not sure how viable it is without a large refactor because it seems like it'd require a fedimint client |
Yeah you are right. It checks the internal lightning balance. Well, I hope that the logic behind the fix is enough to convince. |
benthecarman
approved these changes
Jul 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estimate_ln_feeshould always return amount in sats not msats. This is not what happens when we get the amount from the Bolt11 invoice.