This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
give close button more powers #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/components/Close.tsx
Outdated
Comment on lines
13
to
22
| function handleClose() { | ||
| if (onClose) { | ||
| onClose(); | ||
| } | ||
| if (to) { | ||
| navigate(to); | ||
| } else { |
There was a problem hiding this comment.
should probably put a comment on why you're not using an else if here
futurepaul
force-pushed
the
better-close-button
branch
from
62423fa to
1888ce9
Compare
|
Preview URL: https://mutiny-testnet-hshxga5m0-paulteam.vercel.app |
futurepaul
force-pushed
the
better-close-button
branch
from
1888ce9 to
98f016c
Compare
AnthonyRonning
approved these changes
Dec 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should help with #203
for now it just means the sub-pages in the manager will nav to their parent on close