This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Set invoice labels after fedimint payment #965
Merged
+29
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyRonning
suggested changes
Jan 15, 2024
| @@ -816,7 +816,10 @@ impl<S: MutinyStorage> MutinyWallet<S> { | |||
| .pay_invoice(inv.clone(), labels.clone()) | |||
| .await; | |||
| match payment_result { | |||
| Ok(r) => return Ok(r), | |||
| Ok(r) => { | |||
| self.storage.set_invoice_labels(inv.clone(), labels)?; | |||
There was a problem hiding this comment.
If it happens inside of pay_invoice for node_manager then it should happen inside pay_invoice for fedimint_client, or vice versa.
There was a problem hiding this comment.
That's what I wanted but the fedimint client doesn't have an instance of storage.
There was a problem hiding this comment.
Okay then they can both happen outside for now, that's probably better anyways so they both behave the same.
There was a problem hiding this comment.
Good call, did that for invoice creation as well. Cleaned up code a lot
benthecarman
force-pushed
the
set-last-used-fedi
branch
from
cc97e9e to
1baa89e
Compare
AnthonyRonning
approved these changes
Jan 16, 2024
benthecarman
force-pushed
the
set-last-used-fedi
branch
from
1baa89e to
d0f2539
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963