prettier formatting consistency #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
approved these changes
Jan 13, 2024
nk1tz
commented
Jan 13, 2024
| @@ -9,7 +9,7 @@ | |||
| "check-types": "tsc --noemit", | |||
| "eslint": "eslint src", | |||
| "pre-commit": "pnpm run eslint && pnpm run check-types && pnpm run format", | |||
| "format": "prettier --write \"src/**/*.{ts,tsx,js,jsx,json,css,scss,md}\"", | |||
| "format": "prettier --write \"{.,src/**,e2e/**}/*.{ts,tsx,js,jsx,json,css,scss,md}\"", | |||
There was a problem hiding this comment.
root + src + e2e
{.,src/**,e2e/**}
avoids linting node_modules etc..., can be added to easily
nk1tz
changed the title
trying to discourage deeply nested anything... although I've recently heard a good argument for just using real tabs, so then the display of the tabs can be preferable per dev |
|
thank you for this! since it seems somewhat related to what you're doing here, could you fix this warning for me? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
formatscript applies to all root files ande2e/as well assrc/prettier.config.mjsin tsconfig to avoid eslint complaint inprettier.config.mjsAlso WHY
tabWidth: 4,? :D :D :D my eyes...