Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete contact #824

Merged
merged 1 commit into from
Feb 5, 2024
Merged

delete contact #824

merged 1 commit into from
Feb 5, 2024

Conversation

futurepaul
Copy link
Collaborator

closes #168

@benthecarman
Copy link
Collaborator

benthecarman commented Jan 13, 2024

should wait for MutinyWallet/mutiny-node#962

@futurepaul futurepaul added the blocked Can't fix because... label Jan 15, 2024
Copy link

cloudflare-workers-and-pages bot commented Jan 25, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 125e88c
Status: ✅  Deploy successful!
Preview URL: https://9ae08bde.mutiny-web.pages.dev
Branch Preview URL: https://delete-contact.mutiny-web.pages.dev

View logs

@AnthonyRonning
Copy link
Collaborator

This is no longer blocked.

@AnthonyRonning AnthonyRonning removed the blocked Can't fix because... label Jan 25, 2024
@AnthonyRonning
Copy link
Collaborator

Is this good to merge?

@futurepaul
Copy link
Collaborator Author

Is this good to merge?

yeah just need approval from @TonyGiorgio or @benthecarman

@AnthonyRonning
Copy link
Collaborator

I pled the 5th

Screenshot 2024-02-05 at 4 18 35 PM

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested, was able to delete a contact successfully

@futurepaul futurepaul merged commit 666309f into master Feb 5, 2024
5 checks passed
@futurepaul futurepaul deleted the delete-contact branch February 5, 2024 16:20
@5atoshiNakamoto
Copy link

I see that I can edit a contact now, I don't see an actual way to delete any contact fully.

@benthecarman
Copy link
Collaborator

This hasn't been released yet. Once it is it'll be a button in the edit contact screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to delete a Mutiny contact
4 participants