Lnurl withdrawal support #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think I found a way to solve the fixed amount issue mentioned above |
tompro
force-pushed
the
lnurl-withdrawal
branch
from
5afd272 to
32d6185
Compare
|
what's a good way for me to test this with mutinynet? |
there's one on the faucet |
I can provide you with some fixed amt ones (skips enter amt) from our dev server. Needs to be DM though as they are one time use. Just let me know. |
- route scan/paste navigation to either /send or /receive - similar to /send handling use onMount and global state to communicate and trigger lnUrl handling - experimental trigger lnurlWithdrawal
- allow non fixed amt lnurl withdrawal - fix paste ln url in send
did not add new ui elements but just show the available info with current elements
tompro
force-pushed
the
lnurl-withdrawal
branch
from
32d6185 to
1636470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added very basic support for LNUrl withdrawal requests. I tried to just add the business logic and leave all graphical stuff untouched when possible (you probably don't want me to mess up your CI).
The following UI related things will need some follow up:
Another thing I could not solve is to preset an fixed amount for the withdrawal (when min === max). Whenever I set the initial amount in the amount editor it is immediately reset to 0 from the editor (invoking the callback). I did not mess with that central component.