Warn about hodl invoice #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyRonning
requested changes
Jan 26, 2024
| if (invoice.expire <= Date.now() / 1000) { | ||
| navigate("/search"); | ||
| throw new Error(i18n.t("send.error_expired")); | ||
| } | ||
| const isHodl = await MutinyWallet.is_potential_hodl_invoice( | ||
| source.invoice! |
There was a problem hiding this comment.
why is source here and not not invoice?
There was a problem hiding this comment.
invoice isn't a string, it is a MutinyInvoice
| if (invoice.expire <= Date.now() / 1000) { | ||
| navigate("/search"); | ||
| throw new Error(i18n.t("send.error_expired")); | ||
| } | ||
| const isHodl = await MutinyWallet.is_potential_hodl_invoice( |
There was a problem hiding this comment.
I think this should just happen below in a single spot where it is being set. Now you have it here twice. I think this method can just replace the previous.
|
Not needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we only warned for zeuspay lightning addresses, now we warn for the actual invoices as well