Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use primal cdn for images #858

Merged
merged 1 commit into from
Jan 29, 2024
Merged

use primal cdn for images #858

merged 1 commit into from
Jan 29, 2024

Conversation

futurepaul
Copy link
Collaborator

this uses the s (small) sized images from primal for contacts which should speed up loads. also because it's all from one origin I think the browser can batch these better.

question: is there a way to do the same with our own cache url?

Copy link
Collaborator

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the contact image url in a bunch of other places, should be done there too. Maybe it'd be easier if we actually did this on the backend?

@futurepaul
Copy link
Collaborator Author

search was the main place it was really hurting me, but yeah if you want to rewrite this in the background (or add a separate field?) that might be good. as long as it's not going to complicate sync too much

@benthecarman
Copy link
Collaborator

I guess for global search we aren't able to utilize the backend either way

@futurepaul futurepaul merged commit 9ab49a7 into master Jan 29, 2024
5 checks passed
@futurepaul futurepaul deleted the primal-cdn branch January 29, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants