-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fedimint sweep #862
Fedimint sweep #862
Conversation
8a9ebc7
to
66d64ad
Compare
Deploying with
|
Latest commit: |
835236c
|
Status: | ✅ Deploy successful! |
Preview URL: | https://11d24d52.mutiny-web.pages.dev |
Branch Preview URL: | https://fedimint-sweep.mutiny-web.pages.dev |
Known problems:
|
f2c8d12
to
93e2933
Compare
@TonyGiorgio okay I think I've cleaned this up / addressed your issues, let me know if I'm missing anything |
Awesome thank you so much. I'll test tonight. |
Only frontend issue here is not being able to hit the back button on desktop to edit the amount |
93e2933
to
d810ff6
Compare
2 issues I noticed
|
6127f45
to
87eea9f
Compare
I do think this should be a follow up.
This has been fixed |
Ah yeah, that used to be in the amount editor. Will add an issue. |
87eea9f
to
955d1f6
Compare
955d1f6
to
835236c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tony the frontend master
This does a few refactors on common components.
Does the swap and warns the user when a channel fee may be required. However one critical part is to use
estimate_sweep_federation_fee
once the user has selected the amount so that they can see the fee before they continue. Handles a bit different than the lightning->channel open flow does today which is hard for me to replicate.Relies on MutinyWallet/mutiny-node#995