Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eSats for federation amounts #865

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Add eSats for federation amounts #865

merged 1 commit into from
Feb 5, 2024

Conversation

benalleng
Copy link
Collaborator

Closes #861

image

image

This is a new prop! curious if @futurepaul wants me to not add a prop for this and go another approach

Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6b53ee9
Status: ✅  Deploy successful!
Preview URL: https://11e9ca3d.mutiny-web.pages.dev
Branch Preview URL: https://issue861.mutiny-web.pages.dev

View logs

Copy link
Collaborator

@AnthonyRonning AnthonyRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from me! I was thinking about either doing that, or passing in something string value to parse on but for this, I think isFederation also makes sense. I'll defer to @futurepaul

Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thank you!

edit: just noticed the test is failing due to the changed text

Screenshot 2024-02-05 at 1 41 29 PM

I can fix if you want

Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix the test

@benalleng
Copy link
Collaborator Author

Ooops! thought it was just a flaky test, I can fix it

@futurepaul
Copy link
Collaborator

Ooops! thought it was just a flaky test

many such cases lol

@benalleng
Copy link
Collaborator Author

benalleng commented Feb 5, 2024

should I make a new issue about this roundtrip test?

Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByText('Keep Mutiny open to complete the payment.')


      38 |     await expect(
      39 |         page.getByText("Keep Mutiny open to complete the payment.")
    > 40 |     ).toBeVisible();
         |       ^
      41 |
      42 |     // Locate an SVG inside a div with id "qr"
      43 |     const qrCode = await page.locator("#qr > svg");

        at /home/runner/work/mutiny-web/mutiny-web/e2e/roundtrip.spec.ts:40:7

  1 failed
    [Mobile Chrome] › roundtrip.spec.ts:7:1 › rountrip receive and send ────────────────────────────

I see it has failed in a few PR's

@futurepaul
Copy link
Collaborator

I see it has failed in a few PR's

it's an lsp issue I think, we're looking into it. I'll rerun this test when the lsp is working again

@futurepaul futurepaul merged commit ece5260 into master Feb 5, 2024
5 checks passed
@futurepaul futurepaul deleted the issue861 branch February 5, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show esats for federation sats
3 participants