-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eSats for federation amounts #865
Conversation
Deploying with
|
Latest commit: |
6b53ee9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://11e9ca3d.mutiny-web.pages.dev |
Branch Preview URL: | https://issue861.mutiny-web.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK from me! I was thinking about either doing that, or passing in something string value to parse on but for this, I think isFederation
also makes sense. I'll defer to @futurepaul
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to fix the test
Ooops! thought it was just a flaky test, I can fix it |
many such cases lol |
should I make a new issue about this roundtrip test?
I see it has failed in a few PR's |
it's an lsp issue I think, we're looking into it. I'll rerun this test when the lsp is working again |
Closes #861
This is a new prop! curious if @futurepaul wants me to not add a prop for this and go another approach