Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(deps): bitcoin-waila to 0.4.0 #879

Conversation

oleonardolima
Copy link
Contributor

@oleonardolima oleonardolima commented Feb 12, 2024

bump(deps): bitcoin-waila to 0.4.0

  • for cashu token redeem
  • for fedimint OOBNotes

@oleonardolima oleonardolima force-pushed the feat/add-cashu-token-melting branch 3 times, most recently from 419f571 to 9d504b4 Compare February 12, 2024 14:48
@oleonardolima
Copy link
Contributor Author

I can comeback to this one after the next waila release @benthecarman, any other requirements for cutting a release there ?

@benthecarman
Copy link
Collaborator

@oleonardolima

https://github.com/MutinyWallet/bitcoin-waila/releases/tag/v0.4.0

@oleonardolima oleonardolima force-pushed the feat/add-cashu-token-melting branch from 9d504b4 to e991768 Compare February 20, 2024 16:24
@oleonardolima oleonardolima changed the title wip(bump(deps)): bitcoin-waila to c576d2037efbf6b03b08119fd60a35e3f71… bump(deps): bitcoin-waila to 0.4.0 Feb 20, 2024
@oleonardolima oleonardolima force-pushed the feat/add-cashu-token-melting branch from e991768 to 9c32d61 Compare February 20, 2024 16:26
@oleonardolima oleonardolima marked this pull request as ready for review February 20, 2024 16:26
@oleonardolima
Copy link
Contributor Author

@benthecarman @futurepaul Is it normal for the iOS step fail ?

@futurepaul
Copy link
Collaborator

@benthecarman @futurepaul Is it normal for the iOS step fail ?

Yeah ios build uses env secrets that aren't available to outside PRs

@benthecarman
Copy link
Collaborator

benthecarman commented Feb 21, 2024

Since we added the fedimint dep to waila, we don't want to use the wasm package of it anymore but are instead going to expose through mutiny-node so we don't blow up our download size

I have these PRs if you want to try playing around with it MutinyWallet/mutiny-node#1045 and #894

@oleonardolima
Copy link
Contributor Author

closing in favor of MutinyWallet/mutiny-node#1045 and #894

@oleonardolima oleonardolima deleted the feat/add-cashu-token-melting branch February 22, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants