Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation keys #881

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update translation keys #881

merged 1 commit into from
Feb 15, 2024

Conversation

benalleng
Copy link
Collaborator

@benalleng benalleng commented Feb 13, 2024

Began working with someone to update the korean translation and figured I should go through and try to catch some stray text that was not using translation keys

also adds a small fallback enhancement for the language selector so that if there is no language state it checks if there is a i18n object instead of an empty string

selectedLanguage: state.lang ?? i18n.language

@benalleng benalleng changed the title Catch some stray untranslated text to translation keys [WIP] Catch some stray untranslated text to translation keys Feb 13, 2024
@benalleng benalleng changed the title [WIP] Catch some stray untranslated text to translation keys wip Catch some stray untranslated text to translation keys Feb 13, 2024
@benalleng benalleng force-pushed the updated-korean-translations branch from 3b6fa42 to b147433 Compare February 13, 2024 02:09
Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 109a044
Status: ✅  Deploy successful!
Preview URL: https://dd276837.mutiny-web.pages.dev
Branch Preview URL: https://updated-korean-translations.mutiny-web.pages.dev

View logs

@benalleng benalleng force-pushed the updated-korean-translations branch from b147433 to 109a044 Compare February 15, 2024 01:30
@benalleng benalleng changed the title wip Catch some stray untranslated text to translation keys Update translation keys Feb 15, 2024
@benalleng benalleng marked this pull request as ready for review February 15, 2024 01:34
@benalleng benalleng requested a review from futurepaul February 15, 2024 01:34
Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@futurepaul futurepaul merged commit 713abec into master Feb 15, 2024
5 checks passed
@futurepaul futurepaul deleted the updated-korean-translations branch February 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants