Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set inversion mode for scanner to 'both' #936

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

benthecarman
Copy link
Collaborator

@benthecarman benthecarman commented Mar 23, 2024

Was reading through the docs and seems like this would be beneficial

https://github.com/nimiq/qr-scanner?tab=readme-ov-file#color-inverted-mode

potentially related to the user's issue in #935

@benthecarman benthecarman requested a review from futurepaul March 23, 2024 22:32
Copy link

cloudflare-workers-and-pages bot commented Mar 23, 2024

Deploying mutiny-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e49617
Status: ✅  Deploy successful!
Preview URL: https://dfb35470.mutiny-web.pages.dev
Branch Preview URL: https://inversion-scanner.mutiny-web.pages.dev

View logs

Copy link
Collaborator

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inverted qr is the first don't on this list lol https://www.qrcode-monkey.com/6-reasons-why-your-qr-code-is-not-working/

@benthecarman benthecarman merged commit 208f42f into master Mar 25, 2024
4 of 5 checks passed
@benthecarman benthecarman deleted the inversion-scanner branch March 25, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants