Add new flag and functionality to support checksum digest #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt at #4 (adds `--digestdir` command line option in order to use pre-computed digests) There are a number of assumptions here that'll probably need revisiting: - Issue #4 says to add a true/false flag for checksum manifest; skipping that since it's implied by providing a flag for the manifest base directory - Since we're providing a directory and not a single file, we're assuming that the directory contains a tree of possible manifest files - Assuming manifest files are named `manifest.tsv`; all of them are read into memory - Treating them as tab separated values of "filename" TAB "digest" (checksum) - They're actually whitespace separated values - No commenting or other syntax specified for them The `docs/samples` directory now includes a sample tree of `manifest.tsv` files. NOTE: These changes were rebased in internal repo so functionality will most likely need to be modified and tested.
pdsen-ci
force-pushed
the
master
branch
3 times, most recently
from
a583cd3 to
7c54dd8
Compare
|
Closing as wontfix. This PR has been opened forever and this ship has sailed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at #4 (adds
--digestdircommand line option in order to use pre-computed digests)There are a number of assumptions here that'll probably need revisiting:
manifest.tsv; all of them are read into memoryThe
docs/samplesdirectory now includes a sample tree ofmanifest.tsvfiles.NOTE: These changes were rebased in internal repo so functionality will most likely need to be modified and tested.