Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to main to prep for release. #152

Merged
merged 17 commits into from
Jan 23, 2025
Merged

Merge develop to main to prep for release. #152

merged 17 commits into from
Jan 23, 2025

Conversation

anilnatha
Copy link
Collaborator

🗒️ Summary

This PR addresses the need to merge the develop branch to main to prep for a release.

⚙️ Test Data and/or Report

All changes have been tested against the develop branch and test builds do not generate errrors.

eddiesarevalo and others added 17 commits December 12, 2024 08:07
-Updated page type value that is shown in the search results details.
-Added an expected type that the client will expect from solr. It will then convert all values to arrays and use that type instead.
-This is so that as solr is being updated between strings or string arrays it won't break the client due to unexpected type.
-Changed form-instrument-host reference to instrument_host_name in instrument data types display.
…earch-result

Update Search Result Page Type Label #139
…mplates for some of our context products (investigations, instruments, instrument hosts, targets, telescopes, and facilities). Updated instances where we display these descriptions to use the new utility functions like search results and directory pages.
…duct-descriptions

Updated context product descriptions
-Removed form-instrument-type and form-investigation.
-Removed checkboxes from single filters. The text is now clickable.
-When a single filter is selected the options list becomes hidden.
-Filter title has been added to the selected filter chip.
-Simplified unnecessary use of boolean literals in conditional expression as suggested by Sonarqube.


Add Solr String To String Array Flexibility #137
-Fixed page type to always be treated as an array.
-Fixed title to be treated as an array.
Remove Checkbox From Single Select Filters #141
…sion of portal-wp to 0.0.4 to align with next release version number (was not updated during last release, hence the skip over 0.0.3).
Update @nasapds/wds-react version and other minor updates
@anilnatha anilnatha requested a review from a team as a code owner January 23, 2025 17:57
Copy link
Member

@eddiesarevalo eddiesarevalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on develop. dev and build run without issues. LGTM!

@anilnatha anilnatha merged commit 55152c6 into main Jan 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants