-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop
to main
to prep for release.
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Updated page type value that is shown in the search results details.
-Added an expected type that the client will expect from solr. It will then convert all values to arrays and use that type instead. -This is so that as solr is being updated between strings or string arrays it won't break the client due to unexpected type.
-Changed form-instrument-host reference to instrument_host_name in instrument data types display.
…earch-result Update Search Result Page Type Label #139
…mplates for some of our context products (investigations, instruments, instrument hosts, targets, telescopes, and facilities). Updated instances where we display these descriptions to use the new utility functions like search results and directory pages.
…duct-descriptions Updated context product descriptions
-Removed form-instrument-type and form-investigation.
-Removed checkboxes from single filters. The text is now clickable. -When a single filter is selected the options list becomes hidden. -Filter title has been added to the selected filter chip.
-Simplified unnecessary use of boolean literals in conditional expression as suggested by Sonarqube.
Add Solr String To String Array Flexibility #137
-Fixed page type to always be treated as an array. -Fixed title to be treated as an array.
Remove Checkbox From Single Select Filters #141
…sion of portal-wp to 0.0.4 to align with next release version number (was not updated during last release, hence the skip over 0.0.3).
Update @nasapds/wds-react version and other minor updates
|
eddiesarevalo
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on develop. dev and build run without issues. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
This PR addresses the need to merge the
develop
branch tomain
to prep for a release.⚙️ Test Data and/or Report
All changes have been tested against the
develop
branch and test builds do not generate errrors.