New adf updates #286
Merged
New adf updates #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `load_dataset` function in `plotting_functions.py` that replaces `_load_dataset` function in various plotting scripts. show all plot types on the landing page (`index.html`) and grey out any unavailable types. Currently there is a bug that is not producing the correct html plot page for the tape recorder.
nusbaume
added
code clean-up
nusbaume
requested changes
Feb 25, 2024
|
@nusbaume I think I got these taken care of. Let me know if you see or think of anything else. Thanks! |
nusbaume
reviewed
Feb 27, 2024
lib/adf_variable_defaults.yaml
Outdated
| # Available ADF Default Plot Types | ||
| #+++++++++++++ | ||
|
|
||
| default_ptypes: ["Tables","LatLon","LatLon_Vector","Zonal","Meridonal", |
There was a problem hiding this comment.
Typo here:
Suggested change
| default_ptypes: ["Tables","LatLon","LatLon_Vector","Zonal","Meridonal", | |
| default_ptypes: ["Tables","LatLon","LatLon_Vector","Zonal","Meridional", |
lib/adf_web.py
Outdated
| @@ -653,8 +656,7 @@ def jinja_list(seas_list): | |||
| #Check if the mean plot type page exists for this case: | |||
There was a problem hiding this comment.
I might change this comment too given that we aren't actually checking if the plot type page exists anymore.
nusbaume
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize load dataset
Make
load_datasetfunction inplotting_functions.pythat replaces_load_datasetfunction in various plotting scripts.Now all plotting scripts will call this function from
plotting_functions.pyto get datasets.Website
In
adf_web.py, add a list of defualt plot types and loop over any additional plot types. The point of this is to show all plot types on the landing page (index.html) and grey out any unavailable types. This will keep the main page consistent as well as always showing potential ADF plot types.Also in
adf_web.py, the check for mean_diag html file existence is removed. The reasoning is if a certain plot type (ie LatLon) is created from separate plotting scripts, it will only produce the plots from the last instance on the webpage.In
template_index.htmlthere is code now that will grey out any unavailable plot types.Tape Recorder
Currently there is a bug that is not producing the correct html plot page for the tape recorder. The plot name and web object has been updated to reflect the variable Q specifically in the case a different variable is desired for this plot in the future, like temperature, etc.