Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Observational data common location #167

Merged
merged 6 commits into from
Jan 25, 2025
Merged

Conversation

TeaganKing
Copy link
Collaborator

@TeaganKing TeaganKing commented Jan 21, 2025

This PR will address #166 .

We have created a directory (/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data) for cupid observational data. Existing data should be moved here to assist with organizing data as we move towards an obs data repo. New CUPiD related data should follow this format, hence the PR template update that requests data follows the format COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE.

TODO:

  • Update key metric config file obs data paths
    • /glade/campaign/cesm/development/cross-wg/diagnostic_framework/nmse_validation/fv0.9x1.25 (Isla)
    • /glade/campaign/cesm/development/cross-wg/diagnostic_framework/SMB_data (Gunter)
    • /glade/campaign/cgd/tss/people/mdfowler/FLUXNET2015/ (Meg)
  • Check with relevant parties about location of data and ability to move it
  • Move existing data

Checklist:

@TeaganKing TeaganKing self-assigned this Jan 21, 2025
@TeaganKing TeaganKing linked an issue Jan 22, 2025 that may be closed by this pull request
@TeaganKing
Copy link
Collaborator Author

Per discussions with people who own this data, we'd like to:

  1. Move Meg's data.
  2. Copy Gunter's data and soft link once the LIWG reorganization of data is done.
  3. Move Isla's data (and possibly remove regridded data).

@TeaganKing
Copy link
Collaborator Author

TeaganKing commented Jan 23, 2025

Soft links are temporarily being added to old locations since they are used in the version of CUPiD that is used in beta05.

@TeaganKing TeaganKing marked this pull request as ready for review January 23, 2025 20:05
@TeaganKing TeaganKing requested a review from mnlevy1981 January 23, 2025 20:05
@@ -142,7 +142,7 @@ compute_notebooks:
Greenland_SMB_visual_compare_obs:
parameter_groups:
none:
obs_path: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/SMB_data'
obs_path: '/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data/ice/analysis_datasets/multi_grid/annual_avg/SMB_data'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be CUPiD_obs_data/glc/...; if I have permissions on the disk, I'll move it and update this file

Copy link
Collaborator

@mnlevy1981 mnlevy1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mnlevy1981 mnlevy1981 merged commit be30051 into NCAR:main Jan 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move observational data to CUPiD_obs_data dir and update PR template
2 participants