-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in CESM2 and CESM1 LENS data and fix axes in sea ice plots. #182
Conversation
…add contours to sea ice concentration maps. Still a work in progress.
Great to see the work from the hackathon come in! Are you planning to continue working on the contours and prefer to merge this in before that work is done? If so, could you create an issue ticket describing the changes that you still would like to make? |
I think we want to merge these ASAP so the timeseries and annual cycle plots are part of the standard diagnostics. We'll keep working on the contours issue. I opened issue #183 to document what still needs to happen here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment in main PR conversation.
Fixed I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for making those changes!
Also add contours to sea ice concentration maps. Still a work in progress (contours). This was a combination of items from the hackathon from @duvivier and @dabail10 .
Description of changes:
pre-commit
checks passed (#8 in Adding Notebooks Guide)?/glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data
and ensured that it follows this format within that directory:COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE
?