Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in CESM2 and CESM1 LENS data and fix axes in sea ice plots. #182

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

dabail10
Copy link
Collaborator

@dabail10 dabail10 commented Feb 3, 2025

Also add contours to sea ice concentration maps. Still a work in progress (contours). This was a combination of items from the hackathon from @duvivier and @dabail10 .

Description of changes:

  • Have you followed the guidelines in our Contributor's Guide?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you made sure that the pre-commit checks passed (#8 in Adding Notebooks Guide)?
  • Have you hidden the code cells (#8 in Adding Notebooks Guide) in your notebook?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully tested your changes locally?
  • Have you moved any observational data that you are using to /glade/campaign/cesm/development/cross-wg/diagnostic_framework/CUPiD_obs_data and ensured that it follows this format within that directory: COMPONENT/analysis_datasets/RESOLUTION/PROCESSED_FIELD_TYPE?

…add contours to sea ice concentration maps. Still a work in progress.
@TeaganKing
Copy link
Collaborator

Great to see the work from the hackathon come in! Are you planning to continue working on the contours and prefer to merge this in before that work is done? If so, could you create an issue ticket describing the changes that you still would like to make?

@duvivier
Copy link

duvivier commented Feb 3, 2025

I think we want to merge these ASAP so the timeseries and annual cycle plots are part of the standard diagnostics.

We'll keep working on the contours issue. I opened issue #183 to document what still needs to happen here.

@TeaganKing
Copy link
Collaborator

This looks good to me and is running smoothly.
Screenshot 2025-02-04 at 9 10 18 AM

Two minor things:

  1. nc_time_axis is not being used in the notebook and this causes a warning message. Can this be removed to avoid confusion for users?
=========================== DAG build with warnings ============================
- NotebookRunner: Hemis_seaice_visual_compare_obs_lens -> File('computed_notebook...are_obs_lens.ipynb') -
- /glade/work/tking/cupid_project/other_cupids/dave_cupid/CUPiD/nblibrary/ice/Hemis_seaice_visual_compare_obs_lens.ipynb -
:9:1: 'nc_time_axis' imported but unused
  1. Two of the cells do not have hidden code. Could you please tag these as hide-input so the code doesn't show up in the final compiled jupyter book?
Screenshot 2025-02-04 at 9 10 37 AM Screenshot 2025-02-04 at 9 10 41 AM

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in main PR conversation.

@dabail10
Copy link
Collaborator Author

dabail10 commented Feb 4, 2025

Fixed I think.

Copy link
Collaborator

@TeaganKing TeaganKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for making those changes!

@TeaganKing TeaganKing merged commit a3e0e97 into NCAR:main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants